cake 5 upgrade - implement pr feedback

FriendsOfCake · Sep 18, 2023 · fe876b6 · fe876b6
1 parent ac96c8a
commit fe876b6
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 9 deletions.
diff --git a/config/bootstrap.php b/config/bootstrap.php
diff --git a/phpunit.xml.dist b/phpunit.xml.dist
@@ -1,6 +1,5 @@
 <?xml version="1.0"?>
 <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" backupGlobals="false" bootstrap="./tests/bootstrap.php" colors="true" processIsolation="false" stopOnError="false" stopOnFailure="false" stopOnIncomplete="false" stopOnSkipped="false" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/10.3/phpunit.xsd" cacheDirectory=".phpunit.cache" backupStaticProperties="false">
-  <coverage/>
   <testsuites>
     <testsuite name="CakePdf Plugin Tests">
       <directory>./tests/TestCase</directory>

diff --git a/src/Plugin.php → src/CakePdfPlugin.php b/src/Plugin.php → src/CakePdfPlugin.php
@@ -5,8 +5,15 @@
 
 use Cake\Core\BasePlugin;
 
-class Plugin extends BasePlugin
+class CakePdfPlugin extends BasePlugin
 {
+    /**
+     * Do bootstrap or not
+     *
+     * @var bool
+     */
+    protected bool $bootstrapEnabled = false;
+
     /**
      * Load routes or not
      *

diff --git a/src/View/PdfView.php b/src/View/PdfView.php
@@ -46,9 +46,9 @@ class PdfView extends View
     /**
      * Constructor
      *
-     * @param ?\Cake\Http\ServerRequest $request Request instance.
-     * @param ?\Cake\Http\Response $response Response instance.
-     * @param ?\Cake\Event\EventManager $eventManager Event manager instance.
+     * @param \Cake\Http\ServerRequest|null $request Request instance.
+     * @param \Cake\Http\Response|null $response Response instance.
+     * @param \Cake\Event\EventManager|null $eventManager Event manager instance.
      * @param array $viewOptions View options. See View::$_passedVars for list of
      *   options which get set as class properties.
      * @throws \Cake\Core\Exception\CakeException