Option to delete file on record deletion

[jorisvaesen]

No description provided.

[josegonzalez]

Just fyi, I only merge changes that do not decrease test coverage (including PHPCS!) and have the requisite docs. Happy to work towards that though :)

[josegonzalez]

You need a test for this method as well.

[josegonzalez]

This works now?

[josegonzalez]

@jorisvaesen does this work according to how you'd like it now?

[jorisvaesen]

I did some testing and it seems to work as expected.

[josegonzalez]

Thanks for being patient!

[josegonzalez]

@jorisvaesen added you as a maintainer. Don't abuse your new role of course! I'm looking forward to your help in maintaining this plugin, especially considering the nice features you've worked on :)

[kinglouie]

maybe it is a silly question but how can I delete additionally generated thumbnails with this feature? I thought I would just overwrite the delete method in the writerinterface but the passed array $files only has the path and not the filename, so I cant reference my thumbnail from there.

[kinglouie]

I just did a quick and dirty solution to show the issue.

MyOwnFileWriter.php

public function delete(array $files)
{

    $filesystem = $this->getFilesystem($this->field, $this->settings);
    $results = [];
    $results[] = $this->deletePath($filesystem, $this->entity['file_dir'] . $this->entity['file']);
    $results[] = $this->deletePath($filesystem, $this->entity['file_dir'] . 'thumbnail-' . $this->entity['file']);

    return $results;
}

my solution obviously doesn't work when you have multiple files per entity but my MyOwnFileWriter is specific for my database so in my case there wont be an issue.

[josegonzalez]

@KingLoui since we cannot tell what your original urls will be - that isn't stored - your method is more or less what I would do.

public function delete(array $files)
{
    $files[] = $this->entity['file_dir'] . 'thumbnail-' . $this->entity['file']
    return parent::delete($files);
}

The above might be better.

[jorisvaesen]

For automating this, I was thinking to use the transformer.

Create an extra function, let's say beforeTransform() where thumbnails can be created.
And let transform() only return the array of files which can later be used by the writer to delete all files (including thumbnails).

[josegonzalez]

Maybe, though I'd have to see implementation/docs first. Also, requiring this in the interface would be a BC break, just fyi.

[jorisvaesen]

Indeed.
For 3.x the writers delete function should be overridden (like you said before) but maybe it could be an option for 4.x ?

[josegonzalez]

Sure.