New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix double directory separator in constructFiles when following docs #379

Merged

josegonzalez merged 1 commit into FriendsOfCake:master from jorisvaesen:master

Mar 27, 2016

Collaborator

jorisvaesen commented Mar 27, 2016

Contradiction between code and docs:
Doc says path should end with {DS} but the code appends a forward slash to any path when constructing files.

This results in a double DS on *nix systems: webroot\files\test\\file.txt and something ugly as webroot\files\test/file.txt on windows systems.


          Fix double directory separator in constructFiles when following docum…

0a9f083

…entation

coveralls commented Mar 27, 2016

Coverage remained the same at 100.0% when pulling 0a9f083 on jorisvaesen:master into c298568 on josegonzalez:master.

jorisvaesen added bug 3.x labels

josegonzalez merged commit d123726 into FriendsOfCake:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels