fix: repetitive requests on forum frontend #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davwheat apologies 🙏🏼 allow me to annoy you into reviewing/merging this 👀, it'll be really needed if the user decides to use clockwork: https://discuss.flarum.org/d/30913-huge-performance-problem-refreshing-takes-20sec-or-longer |
davwheat
approved these changes
Jul 11, 2022
|
Release 1.0.1 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Fixes multiple logging of the requests directed to the forum frontend making debugging difficult.
Reviewers should focus on:
This was happening because when loading the forum page flarum runs inner API requests using its API client to get the list of discussions for example, and the clockwork middleware was running multiple times due to that.
Screenshot