Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: dispatch a merging event #51

Merged
merged 1 commit into from
Aug 1, 2023
Merged

feat: dispatch a merging event #51

merged 1 commit into from
Aug 1, 2023

Conversation

SychO9
Copy link
Contributor

@SychO9 SychO9 commented Jul 30, 2023 •
edited
Loading

Supersedes #50

Changes proposed in this pull request:
Dispatches an event before the discussion is saved and other discussions are deleted. Allows other extensions to introduce custom behavior. I think this is cleaner and keeps the current logic simple and straightforward.

Reviewers should focus on:

Screenshot

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).

Required changes:

@SychO9 SychO9 mentioned this pull request Jul 30, 2023
Closed
3 tasks
@SychO9 SychO9 requested a review from dsevillamartin July 30, 2023 08:38
@imorland imorland merged commit b2fa152 into FriendsOfFlarum:master Aug 1, 2023
@SychO9 SychO9 deleted the sm/dispatch-merging-event branch August 4, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imorland imorland imorland approved these changes

@luceos luceos luceos approved these changes

@dsevillamartin dsevillamartin Awaiting requested review from dsevillamartin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SychO9 @luceos @imorland