Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wip: new merging logic, updated tests #56

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

wip: new merging logic, updated tests #56

wants to merge 8 commits into from

Conversation

imorland
Copy link
Member

@imorland imorland commented Nov 3, 2023 •
edited
Loading

  • Delegate merge operations to the queue, where available
  • If flarum/lock is available, lock the discussion(s) whilst the merge is pending/in-progress
  • Notify the merge actor when complete
  • New merge handler, should overcome previous numbering and constraint related issues
  • Tests for most common merge operations

New handler inspired by https://github.com/SychO9/flarum-move-posts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imorland @StyleCIBot