Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
Reviewers should focus on:
This logic does not work for anonymous votes. It'd make sense to allow to delete an entire reaction type (I really hate the terminology being the same 😮💨), but I wasn't sure what API URL to use for that. As it stands already, it's not clear whether the endpoint is for a
post_reaction
orreaction
ID... and since/posts/{id}/reactions
returnspost_reactions
, I don't know whether the mismatch can be avoided at all.Screenshot
Confirmed
composer test
).