fix: don't apply recaptcha requirements when it's not configured #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mood lol. We might want to strip the settings of whitespace as well. Since the fields are required, users might set them to |
|
True, though I have no idea why someone would purposely bypass this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #47
Changes proposed in this pull request:
This prevents ReCaptcha code from attempting to load, and prevents backend validation, when ReCaptcha isn't configured.
(God I'm rusty at this... let me know what I've inevitably missed!)
Reviewers should focus on:
Screenshot
With config:
Without config:
Confirmed
composer test).