Status-Werte als Klassen-Konstanten #102
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Die Status-Welder für Entry und Category sind nun in den Klassen als Konstanten hnterlegt. Dadurch gibt es eine zentrale Stelle im Code, an der sie definiert werden, und nichtmehr im YForm-Field (Choive-Values). Das macht es der IDE und RexStan leichter.
Außerdem wird der Code lesbarer:
$status = 1
ist weniger aussagefähig als$status = Entry::ONLINE
.Die Choice-Felder erhalten die Werte nun via Callback einer statischen Methode in der jeweiligen Klasse.