Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopeninig: Use the correct Symfony Controller class based on Symfony version #681

Merged
merged 12 commits into from
Apr 10, 2019
Merged

Reopeninig: Use the correct Symfony Controller class based on Symfony version #681

merged 12 commits into from
Apr 10, 2019

Conversation

snebes
Copy link
Contributor

@snebes snebes commented Apr 10, 2019

Ref #671

I hate to have to do this, but at this point in time, Symfony is throwing the deprecation messages without a way ignore them. Even their tests are checking for them. This required a tweak to the travis config.

Also updated 2 interfaces with incorrect docBlocks.

@XWB XWB merged commit a014329 into FriendsOfSymfony:master Apr 10, 2019
@XWB
Copy link
Member

XWB commented Apr 10, 2019

Nice, thanks @snebes :)

@snebes snebes deleted the deprecation-bandaid branch April 10, 2019 12:32
@onEXHovia
Copy link

@XWB this is a BC break for me on version symfony 4.3

An exception has been thrown during the rendering of a template ("Service "fos_comment.manager.thread" not found: even though it exists in the app's container, the container inside "App\Controller\ThreadController" is a smaller service locator that only knows about the "doctrine", "form.factory", "http_kernel", "parameter_bag", "request_stack", "router", "security.authorization_checker", "security.csrf.token_manager", "security.token_storage", "serializer", "session", "templating" and "twig" services. Try using dependency injection instead.").

AbstractController uses a limited dependencies in container. More information:
symfony/symfony-docs#9926 (comment)
symfony/symfony-docs#9926 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants