Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 7 #470

Closed
tacman opened this issue Nov 28, 2023 · 6 comments
Closed

Support Symfony 7 #470

tacman opened this issue Nov 28, 2023 · 6 comments

Comments

@tacman
Copy link
Contributor

tacman commented Nov 28, 2023

Symfony 7 will be out in a few days. It would be great if the bundle could be installed when using it.

@tacman
Copy link
Contributor Author

tacman commented Nov 29, 2023

Symfony 7 is out.

Problem 2
    - Root composer.json requires friendsofsymfony/jsrouting-bundle ^3.3 -> satisfiable by friendsofsymfony/jsrouting-bundle[3.3.0].
    - friendsofsymfony/jsrouting-bundle 3.3.0 requires symfony/framework-bundle ^5.4|^6.0 -> found symfony/framework-bundle[v5.4.0, ..., v5.4.32, v6.0.0, ..., v6.4.0] but these were not loaded, likely because it conflicts with another require.

I can submit a PR, but what do you think of bumping the requirements to only supported versions of Symfony? That is

image

@tacman
Copy link
Contributor Author

tacman commented Nov 30, 2023

I see there's a push to the master branch, can you create a new release please?

@tobias-93
Copy link
Collaborator

My plan was to release it simultaneously with #464, since there were also some requests for that. For now you could use dev-master@dev in your Composer constraints.

By the way: why the hurry in updating to SF7.0? Feature-wise 6.4 and 7.0 are the same, and 6.4 is LTS...

@tacman
Copy link
Contributor Author

tacman commented Nov 30, 2023 via email

@tacman
Copy link
Contributor Author

tacman commented Dec 4, 2023

Any downside to releasing a version that works with Version 7, and another one when #464 is fixed?

@tobias-93
Copy link
Collaborator

Update has been released with version 3.4.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants