Fixing HTTP status code definition

[SebScoFr]

In oauth2-php/lib/OAuth2.php, status code should be changed from

const HTTP_FOUND = '302 Found';
const HTTP_BAD_REQUEST = '400 Bad Request';
const HTTP_UNAUTHORIZED = '401 Unauthorized';
const HTTP_FORBIDDEN = '403 Forbidden';
const HTTP_UNAVAILABLE = '503 Service Unavailable';

to

const HTTP_FOUND = Response::HTTP_FOUND;
const HTTP_BAD_REQUEST = Response::HTTP_BAD_REQUEST;
const HTTP_UNAUTHORIZED = Response::HTTP_UNAUTHORIZED;
const HTTP_FORBIDDEN = Response::HTTP_FORBIDDEN;
const HTTP_UNAVAILABLE = Response::HTTP_SERVICE_UNAVAILABLE;

The reason for that is that the lib now fails with SF4 with
Notice: A non well formed numeric value encountered

This happens here, oauth2-php/lib/OAuth2ServerException.php

public function getHttpResponse()
{
    return new Response(
        $this->getResponseBody(),
        $this->getHttpCode(),
        $this->getResponseHeaders()
    );
}

And Symfony Response class is expecting this

public function __construct($content = '', int $status = 200, array $headers = array())
{
    $this->headers = new ResponseHeaderBag($headers);
    $this->setContent($content);
    $this->setStatusCode($status);
    $this->setProtocolVersion('1.0');
}

$status must be a well-formed int.

EDIT: I followed @Spomky suggestion and updated the PR.

[Spomky]

Best would be to mark those constants as deprecated and directly use Response object ones

[SebScoFr]

Thanks @Spomky, done.

[andythorne]

Any news on getting this merged? It seems to fix it...

[GuilhemN]

The composer.json should then be update to remove symfony/http-foundation old versions support. (imo we can remove 2.x support)

[recons]

@GuilhemN will it be merged in the near future?

[GuilhemN]

@recons same answer. This is not ready to be merged. Please submit a corrected PR if you want it to go faster.

[SebScoFr]

@GuilhemN Thanks for the comment. I've updated the PR.

[recons]

@SebScoFr you need to update required composer php version and .travis.yml also

[SebScoFr]

Should be all good now

[GuilhemN]

Great, thank you @SebScoFr :)