Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sort packages #121

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Conversation

connorhu
Copy link
Collaborator

@connorhu connorhu commented Feb 6, 2024

minor add

@thePanz
Copy link
Member

thePanz commented Feb 7, 2024

how can we ensure that the ordering is kept?

the reqs are not sorted as an example, we might need to use compose-normalizer and add a CI action?

@connorhu
Copy link
Collaborator Author

composer does the sorting when you add new req or req-dev package:
https://getcomposer.org/doc/06-config.md#sort-packages

@thePanz
Copy link
Member

thePanz commented Feb 17, 2024

composer does the sorting when you add new req or req-dev package: https://getcomposer.org/doc/06-config.md#sort-packages

Yeah, i know that.
What I was addressing is the fact that our composer.json is not yet sorted, and there is nothing in place to verify that the sorting is respected on merging new PRs :)

@connorhu
Copy link
Collaborator Author

connorhu commented Feb 17, 2024

Oooo i see. Sorry I didn't notice that the ext's are not sorted.
(btw here is the sorting logic: https://github.com/composer/composer/blob/596a384c973dfb551bfb0c7099ae7b91df60aa77/src/Composer/Json/JsonManipulator.php#L126-L155 )

@thePanz thePanz merged commit b756c43 into FriendsOfSymfony1:master Feb 18, 2024
5 checks passed
@connorhu connorhu deleted the fix/sort-packages branch February 18, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants