Phpdoc improvements #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arendvw
commented
Jun 16, 2016
arendvw
commented
- Improved comments from the doctrine point of view
- Added getter/setter @method comments for base comments
- Added better indenting of @Property comments
- Added better type annotations (conversion from doctrine type to php, and hinting for date and time formats)
- Added available options for enum types (and format for time based formats)
- Improved comments from the doctrine point of view - Added getter/setter comments for base comments - Added better indenting of @Property and @method comments - Added better php-typing (conversion from doctrine type to php, and hinting for date and time formats - Added available options for enum types.
- Improved comments from the doctrine point of view - Added getter/setter comments for base comments - Added better indenting of @Property and @method comments - Added better php-typing (conversion from doctrine type to php, and hinting for date and time formats - Added available options for enum types.
| } else { | ||
| $commentOptions[] = sprintf("Type: %s(%s)", $column["type"], $column["length"]); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Be careful about CS, we are in symfony1 not Symfony 2.
Should be :
}
else
{There was a problem hiding this comment.
Ok, thanks for the heads up - this file did not follow the conventions to begin with in many cases, but I've adjusted the committed part.
|
Could you provide a sample of a generated class before and after your changes? |
|
A (payment) transaction table: Before After: |
|
And sfGuardUser (before): sfGuardUser after: |
- Fixed CS issues - Getters/Setters would have a different name if the base class had lowercase prefixes.
|
Ok for me. Can you squash your commits into only one? |
- Improved comments from the doctrine point of view - Added getter/setter comments for base comments - Added better indenting of @Property and @method comments - Added better php-typing (conversion from doctrine type to php, and hinting for date and time formats - Added available options for enum types. feature(better-comments): - Improved comments from the doctrine point of view - Added getter/setter comments for base comments - Added better indenting of @Property and @method comments - Added better php-typing (conversion from doctrine type to php, and hinting for date and time formats - Added available options for enum types. - Added timestamp autocomplete - Fixed CS issues - Getters/Setters would have a different name if the base class had lowercase prefixes.
…1 into dev-phpdoc-improvements
|
Sure, is this what you meant? Or should I cherry pick the commit into a new branch? |
|
This is what we mean: https://ariejan.net/2011/07/05/git-squash-your-latests-commits-into-one/ Thanks for the PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.