Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 7.2 - deprecated "each" calls #41

Merged
merged 2 commits into from
Mar 20, 2018
Merged

Conversation

vitaliytv
Copy link

No description provided.

@vitaliytv vitaliytv force-pushed the master branch 2 times, most recently from d738ed5 to f44654a Compare March 13, 2018 13:23
@vitaliytv
Copy link
Author

squashed

$matchedComponents[] = $table->getComponentName();
}
foreach($inheritanceMap as $key => $value) {
$key = $this->_tables[$component]->getFieldName($key);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove these tabs?

PHP 7.2 - deprecated "each" calls
remove tab
@vitaliytv
Copy link
Author

add php 7.2 to travis

Copy link

@j0k3r j0k3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok

@j0k3r j0k3r merged commit ca85260 into FriendsOfSymfony1:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants