Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert strict decimal comparison #80

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Revert strict decimal comparison #80

merged 1 commit into from
Jun 25, 2020

Conversation

iricketson
Copy link

@iricketson iricketson commented Jun 19, 2020 •
edited
Loading

Reverts BC break with decimal validation of strings that contain trailing zeroes (e.g. '123.00').

Fixes #75

@iricketson iricketson mentioned this pull request Jun 19, 2020
Closed
@j0k3r
Copy link

j0k3r commented Jun 25, 2020

Good job @iricketson & @alquerci

@j0k3r j0k3r merged commit 49f2549 into FriendsOfSymfony1:master Jun 25, 2020
@hcomnetworkers
Copy link

Hi,

thank you very much for the fix!
Unfortunately we need the fix for our upgrade to PHP 7.4.
Do you have an ETA for the next release?

Thanks again for keeping this project alive.
Really appreciated.

@j0k3r
Copy link

j0k3r commented Jul 10, 2020

@hcomnetworkers https://github.com/FriendsOfSymfony1/doctrine1/releases/tag/v1.3.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j0k3r j0k3r j0k3r approved these changes

@alquerci alquerci alquerci approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data type validation can fail for float/double
4 participants
@iricketson @j0k3r @hcomnetworkers @alquerci