A few more php 8.1 things #92
Conversation
| @@ -118,7 +118,7 @@ public function flush() | |||
| $coll->takeSnapshot(); | |||
| } | |||
| $this->_initializedRelations = null; | |||
| $this->_collections = null; | |||
| $this->_collections = array(); | |||
There was a problem hiding this comment.
This is not really related to 8.1. Flushing twice caused a warning due to the $_collection being set to null.
| @@ -1704,7 +1704,7 @@ public function findByDql($dql, $params = array(), $hydrationMode = null) | |||
| * Find records basing on a field. | |||
| * | |||
| * @param string $column field for the WHERE clause | |||
| * @param string $value prepared statement parameter | |||
| * @param string|array $value prepared statement parameter | |||
There was a problem hiding this comment.
These two are not related to 8.1 as well, but it's nice in editors with code assist to know the correct types.
thirsch
force-pushed
the
feature/php-8.1-support
branch
from
71e007b to
f7793f0
Compare
|
Thx @thePanz for merging the commit. The release v1.4.0-RC1 is marked as "pre-release", is there a "final release" v.1.4.x marked as "latest" planed soon or are there any open issues / pull-requests? |
|
@JohannesTyra I tagged v1.4.0-RC2 The aim is to gather more feedback from users before releasing the v1.4.0 |
|
@thePanz Thx. I will check it asap. |
|
@thePanz i found something. Its on building the doctrine classes via console. `
PHP Deprecated: strtolower(): Passing null to parameter #1 ($string) of type string is deprecated in vendor/friendsofsymfony1/doctrine1/lib/Doctrine/Table.php on line 1182 Afterwords its IN the generated base classes und results in corrupted files. |
@thePanz as the fix for this is merged now, how about a release 1.4.0? |
|
Yup, why not :) |
I'm currently comparing the current master to our fork with php 8.0 and 8.1 fixes and stumbled upon these changes.