New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PHP] Replace default $flags variable with 0 #307

Merged

connorhu merged 1 commit into FriendsOfSymfony1:master from iricketson:fix/sfValidatorIp

Jan 14, 2024

Contributor

iricketson commented Jan 11, 2024 •

edited

Loading

The sfValidatorIp class sets the $flags variable to null by default, which is passed into the $options parameter of the filter_var function and triggers a PHP deprecation error:

Deprecated: filter_var(): Passing null to parameter #3 ($options) of type array|int is deprecated in /path/to/friendsofsymfony1/symfony1/lib/validator/sfValidatorIp.class.php on line 104

This PR simply sets the default value of $flags to 0 (zero), which is the default filter_var $options value when not passed.


          Replace default with 0

d60c2c1

thirsch approved these changes

View reviewed changes

alquerci approved these changes

View reviewed changes

connorhu approved these changes

View reviewed changes

connorhu merged commit d0f559c into FriendsOfSymfony1:master

6 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet