Update sfTask.class.php #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey ! |
|
Do you use php 5.5 by now at L'express ? |
|
Not with symfony1. |
|
Can you squash your commit? Then I'll merge it. |
|
Ping @JLepeltier ? :) |
Remove deprecated preg_replace with 'e' pattern modifier on sfTask/getDetailedDescription method Update sfTaskTest.php Add sfTask/getDetailedDescription test Update sfTaskTest.php Update sfTask.class.php
|
Sorry, I don't now how to squash with the github web interface :( 2014-04-29 12:23 GMT+02:00 Jeremy notifications@github.com:
Jérôme Lepeltier |
|
Well, you cannot use the Github interface :) You should do it manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove deprecated preg_replace with 'e' pattern modifier on sfTask/getDetailedDescription method