Support alternate klipper venv paths

[kageurufu]

Summary by Sourcery

Support alternate Klipper virtual environment paths by allowing the path to be set via the KLIPPER_VENV environment variable.

Enhancements:

• Allow customization of the Klipper virtual environment path by introducing an environment variable KLIPPER_VENV.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request introduces support for alternate Klipper virtual environment paths by modifying the installation script to use an environment variable for the Klipper venv path.

File-Level Changes

Change	Details	Files
Introduce support for custom Klipper virtual environment paths	Replace hardcoded Klipper venv path with an environment variable Use KLIPPER_VENV environment variable if set, otherwise fallback to default path	install.sh

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @kageurufu - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[kageurufu]

ok that sourcery thing is black magic
i need to use it on my projects 🤣

[Frix-x]

That's a good idea! Do you think it can be worth adding the other variables from ENV vars as well?

And yeah, I just tried Sourcery to see how it would works and found that it's actually giving pretty good review. Not always worth it but sometimes it can find problems and give pretty useful hints to get better code :) So I decided to keep it!

[kageurufu]

I need to do something to fix the moonraker.conf when installed this way, perhaps embed a template in the install.sh and populate it then? How attached are you to having the moonraker.conf separate?

…

On Thu, Sep 12, 2024 at 5:00 AM Félix Boisselier ***@***.***> wrote: That's a good idea! — Reply to this email directly, view it on GitHub <#154 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB7NJYKDYK3T2ILDRL45ZLZWF67PAVCNFSM6AAAAABOCKE6LGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBWGA4TKNRYGE> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[Frix-x]

Sure you can do this. I found it was easy to have it separated to just cat moonraker.conf > target.conf, but if you want to fill a template with custom values, you can embed it in the install.sh without any problem.

[kageurufu]

Done! Lemme know what you think