Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lookup table from rustc-std builds #152

Merged
merged 1 commit into from
May 17, 2024

Conversation

GnomedDev
Copy link
Contributor

Currently, at least 4kb of every Rust binary is taken up by miniz_oxide for this lookup table that can be computed at runtime without ruining performance. This is most likely a performance hit, but since this is only used by libstd for panic handling/backtraces (which are cold paths) this should be acceptable, at least under the rustc-dep-of-std flag.

I would give cargo bench output, but I can't get them running on my Arch Linux install due to -lminiz being missing.

@oyvindln
Copy link
Collaborator

Afaik the performance gain from using the lookup table here is mainly relevant for very short data as it's used when generating the huffman table so it probably won't be that relevant for rustc-dep-of-std

It was introduced in this pr:
#132

@oyvindln oyvindln merged commit 434d9ab into Frommi:master May 17, 2024
7 of 8 checks passed
@oyvindln
Copy link
Collaborator

I've pushed a 0.7.3 version with that includes update to crates.io

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants