Remove lookup table from rustc-std builds #152
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, at least 4kb of every Rust binary is taken up by miniz_oxide for this lookup table that can be computed at runtime without ruining performance. This is most likely a performance hit, but since this is only used by libstd for panic handling/backtraces (which are cold paths) this should be acceptable, at least under the
rustc-dep-of-std
flag.I would give
cargo bench
output, but I can't get them running on my Arch Linux install due to-lminiz
being missing.