Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Breaking Change Book #326

Merged
merged 6 commits into from
Jun 24, 2024
Merged

Conversation

calldelegation
Copy link
Contributor

@calldelegation calldelegation marked this pull request as ready for review June 20, 2024 19:46
@calldelegation calldelegation requested review from a team, matt-user, naz3eh and laishawadhwa and removed request for a team June 20, 2024 19:46
@calldelegation calldelegation self-assigned this Jun 20, 2024
@calldelegation
Copy link
Contributor Author

calldelegation commented Jun 20, 2024

Remove old breaking change log guide

Copy link
Contributor

@matt-user matt-user left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have to look at the deployment but looks good

contentlayer.config.ts Outdated Show resolved Hide resolved
@matt-user
Copy link
Contributor

The link on the summary page for breaking changes is 404. Also the link check in the ci seems to be flagging something w beta-4

@calldelegation
Copy link
Contributor Author

Copy link
Member

@naz3eh naz3eh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it LGTM! Just the inverted commas and a few other things that Matt mentioned need to be fixed.

@naz3eh naz3eh self-requested a review June 24, 2024 16:41
Copy link
Member

@naz3eh naz3eh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! This PR is ready to be merged

@calldelegation calldelegation merged commit 41e25fe into master Jun 24, 2024
11 of 13 checks passed
@calldelegation calldelegation deleted the docs/add-breaking-change-book branch June 24, 2024 16:53
matt-user pushed a commit that referenced this pull request Dec 10, 2024
* ready for first review

* ready for first review

* Update scripts/generate-links/getDocs.mjs

* removal of old guide

* fix

* fixes coming
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants