Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add TS linting check in CI #350

Merged
merged 11 commits into from
Oct 28, 2024
Merged

feat: add TS linting check in CI #350

merged 11 commits into from
Oct 28, 2024

Conversation

viraj124
Copy link
Contributor

@viraj124 viraj124 commented Oct 22, 2024 •
edited
Loading

@viraj124 viraj124 requested a review from a team as a code owner October 22, 2024 10:12
@viraj124 viraj124 changed the title fix: TS Linting for smart contract package fix: TS Linting in solidity-contracts package Oct 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 22, 2024 •
edited
Loading

This PR is published in NPM with version ****

@DefiCake
Copy link
Member

CIs are failing

@viraj124
Copy link
Contributor Author

viraj124 commented Oct 23, 2024 •
edited
Loading

CIs are failing

Yeah still wip

@viraj124 viraj124 marked this pull request as draft October 23, 2024 07:33
PraneshASP
PraneshASP requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@PraneshASP PraneshASP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few typos

packages/solidity-contracts/deploy/upgradeTest/prepareUpgrade.fuel_message_portal_v3.ts Outdated Show resolved Hide resolved
packages/solidity-contracts/deploy/upgradeTest/prepareUpgrade.erc20_gateway_v4.ts Outdated Show resolved Hide resolved
packages/solidity-contracts/deploy/upgradeTest/prepareUpgrade.chain_state.ts Outdated Show resolved Hide resolved
@viraj124 viraj124 changed the title fix: TS Linting in solidity-contracts package fix: TS Linting in all packages Oct 25, 2024
@viraj124 viraj124 changed the title fix: TS Linting in all packages fix: TS Linting Oct 25, 2024
@viraj124 viraj124 marked this pull request as ready for review October 25, 2024 11:25
@viraj124 viraj124 changed the title fix: TS Linting feat: add TS linting check in CI Oct 25, 2024
viraj124 and others added 2 commits October 25, 2024 20:49
@viraj124 viraj124 merged commit 6315bbb into main Oct 28, 2024
11 checks passed
@viraj124 viraj124 deleted the viraj124/346-fix-ci-linting-contracts branch October 28, 2024 09:13
@github-actions github-actions bot mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DefiCake DefiCake DefiCake approved these changes

@PraneshASP PraneshASP PraneshASP approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(feat): add ts linting check in ci
3 participants
@viraj124 @DefiCake @PraneshASP