Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: render connect modal using portal #270

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

helciofranco
Copy link
Member

@helciofranco helciofranco commented Sep 20, 2024

The Connect modal had a z-index issue because it was rendered directly inside the actual content in thebody.
This caused it to be hidden behind other dialogs that use Portals in external projects.


📷 Demo
Screenshot 2024-09-20 at 13 18 10

Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2024 5:07pm

Copy link
Contributor

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 61.13% 140 / 229
🔵 Statements 61.13% 140 / 229
🔵 Functions 56.66% 17 / 30
🔵 Branches 86.95% 20 / 23
File CoverageNo changed files found.
Generated in workflow #684

Copy link
Contributor

Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 16 / 16
🔵 Statements 100% 16 / 16
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #684

Copy link
Contributor

Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)

Status Category Percentage Covered / Total
🔵 Lines 100% 19 / 19
🔵 Statements 100% 19 / 19
🔵 Functions 100% 1 / 1
🔵 Branches 100% 1 / 1
File CoverageNo changed files found.
Generated in workflow #684

Copy link
Contributor

This PR is published in NPM with version 0.28.2-preview-e63f612950627980c2b9782d9a731752c639ac3d

@helciofranco helciofranco marked this pull request as ready for review September 20, 2024 17:18
@helciofranco helciofranco enabled auto-merge (squash) September 20, 2024 17:20
@helciofranco helciofranco merged commit e2c5149 into main Sep 21, 2024
20 of 21 checks passed
@helciofranco helciofranco deleted the hf/fix/react-portal branch September 21, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants