feat: add request validation #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luizstacio
requested review from
pedronauck,
LuizAsFight,
helciofranco,
arthurgeron and
rodrigobranas
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Coverage Report for Fuel Wallet (./packages/fuel-wallet)
File CoverageNo changed files found. |
Coverage Report for Fuel Development Wallet (./packages/fuel-development-wallet)
File CoverageNo changed files found. |
Coverage Report for Fuelet Wallet (./packages/fuelet-wallet)
File CoverageNo changed files found. |
arthurgeron
reviewed
Sep 22, 2024
| if (wagmiConfig) { | ||
| const account = getAccount(wagmiConfig); | ||
| if (account) { | ||
| requestValidations(); |
There was a problem hiding this comment.
Why would we request validations on connection error?
arthurgeron
reviewed
Sep 22, 2024
arthurgeron
reviewed
Sep 22, 2024
Co-authored-by: Hélcio Franco <github@helciofranco.com>
Co-authored-by: Hélcio Franco <github@helciofranco.com>
helciofranco
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #260
Add signMessage before connecting to application.