Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enforce target network #285

Merged
merged 36 commits into from
Sep 24, 2024
Merged

feat: enforce target network #285

merged 36 commits into from
Sep 24, 2024

Conversation

arthurgeron
Copy link
Contributor

@arthurgeron arthurgeron commented Sep 24, 2024 •
edited
Loading

Changes

@fuels/react

Usage example can be found seen in examples/react-app

Other

  • Moved icons to a shared folder (i.e. src/icons)
  • Moved DialogContent content to src/ui/Dialog/components/Content

image

@vercel Vercel
Copy link

vercel bot commented Sep 24, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fuel-connectors ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 11:32pm

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 24, 2024 •
edited
Loading

Coverage Report for Fuel Wallet (./packages/fuel-wallet)

Status Category Percentage Covered / Total
🔵 Lines 61.3% 141 / 230
🔵 Statements 61.3% 141 / 230
🔵 Functions 56.66% 17 / 30
🔵 Branches 86.95% 20 / 23
File CoverageNo changed files found.
Generated in workflow #735

luizstacio
luizstacio requested changes Sep 24, 2024
View reviewed changes
Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change also requires a change on the connectors for all of them to support receive a custom provider.

packages/react/src/providers/FuelProvider.tsx Outdated Show resolved Hide resolved
@arthurgeron arthurgeron marked this pull request as draft September 24, 2024 16:11
This was linked to issues Sep 24, 2024
2make sure user is not in wrong network FuelLabs/fuel-explorer#523
Closed
Connectors popup being cut on bottom #250
Closed
@arthurgeron arthurgeron enabled auto-merge (squash) September 24, 2024 23:13
LuizAsFight
LuizAsFight requested changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@LuizAsFight LuizAsFight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's missing to check changes from wallet. if I change to a unsupported network directly inside of my wallet, the app is not detecting it

luizstacio
luizstacio approved these changes Sep 24, 2024
View reviewed changes
Copy link
Member

@luizstacio luizstacio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arthurgeron arthurgeron merged commit 65924f3 into main Sep 24, 2024
10 checks passed
@arthurgeron arthurgeron deleted the ag/feat/select-network branch September 24, 2024 23:50
@fuel-service-user fuel-service-user mentioned this pull request Sep 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LuizAsFight LuizAsFight LuizAsFight approved these changes

@luizstacio luizstacio luizstacio approved these changes

@pedronauck pedronauck Awaiting requested review from pedronauck pedronauck is a code owner

@helciofranco helciofranco Awaiting requested review from helciofranco helciofranco is a code owner

@rodrigobranas rodrigobranas Awaiting requested review from rodrigobranas rodrigobranas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2make sure user is not in wrong network Connectors popup being cut on bottom
3 participants
@arthurgeron @luizstacio @LuizAsFight