Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peer Report Configuration #1340

Open
MitchTurner opened this issue Aug 31, 2023 · 2 comments
Open

Peer Report Configuration #1340

MitchTurner opened this issue Aug 31, 2023 · 2 comments

Comments

@MitchTurner
Copy link
Member

MitchTurner commented Aug 31, 2023 •
edited by xgreenx
Loading

As a follow-up to #943 we might want to provide a way for the client operator to modify the PeerReportConfig that is passed to the P2PAdapter.

It should be configurable via CLI and maybe it worth to have a separate --p2p-reputation config.
@MitchTurner MitchTurner mentioned this issue Aug 31, 2023
Merged
@MitchTurner
Copy link
Member Author

This applies to a number of locations marked with TODOs and this issue number, including heartbeat peer rep, etc.

This was referenced Sep 22, 2023
Merged
Open
xgreenx added a commit that referenced this issue Sep 25, 2023
@MitchTurner @xgreenx
Remove todo from code and provide some preliminary peer review config…
2152e39 
… values (#1380)

This was left behind from this work:
#1356

As we did for the syncing peer config, we left hard-coded values for
each variant. The followup work for that is tracked here:
#1340

---------

Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
crypto523 pushed a commit to crypto523/fuel-core that referenced this issue Oct 7, 2024
@xgreenx
Remove todo from code and provide some preliminary peer review config…
ca6728d 
… values (#1380)

This was left behind from this work:
FuelLabs/fuel-core#1356

As we did for the syncing peer config, we left hard-coded values for
each variant. The followup work for that is tracked here:
FuelLabs/fuel-core#1340

---------

Co-authored-by: Green Baneling <XgreenX9999@gmail.com>
@MitchTurner
Copy link
Member Author

This is probably a good thing to have, but no one is asking for it.

On the other hand, any values we are using inside peer review are arbitrary, so having some control of them is probably important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MitchTurner