New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the `Block` by reference and return the `ValidationResult` #1882

Closed

xgreenx opened this issue May 7, 2024 · 0 comments

Assignees

Labels

tech-debt

Collaborator

xgreenx commented May 7, 2024

          We need to pass the `Block` by reference and return the `ValidationResult` without the `Block` type inside. It can be follow-up=)

Originally posted by @xgreenx in #1873 (comment)

The text was updated successfully, but these errors were encountered:

xgreenx added the tech-debt label

xgreenx assigned MitchTurner

MitchTurner mentioned this issue

Use ref instead of owned Block in validation #1886

Merged

9 tasks

xgreenx added a commit that referenced this issue


          Use ref instead of owned Block in validation (#1886)

32600db

#1882

## Checklist
- [ ] Breaking changes are clearly marked as such in the PR description
and changelog
- [ ] New behavior is reflected in tests
- [ ] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [ ] I have created follow-up issues caused by this PR and linked them
here

### After merging, notify other teams

[Add or remove entries as needed]

- [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/)
- [ ] [Sway compiler](https://github.com/FuelLabs/sway/)
- [ ] [Platform
documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+)
(for out-of-organization contributors, the person merging the PR will do
this)
- [ ] Someone else?

---------

Co-authored-by: xgreenx <xgreenx9999@gmail.com>

MitchTurner closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment