Handle ExecutionResult and ValidationResult separately in Wasm executor
#1887
Assignees
Comments
9 tasks
4 tasks
xgreenx
added a commit
that referenced
this issue
Sep 17, 2024
…2199) Closes #1887 Closes FuelLabs/fuel-vm#797 Related #2114 Related #2133 This PR contains several small breaking changes to the WASM interface: - Get the module to execute WASM byte code from the storage first, an fallback to the built-in version in the case of the `FUEL_ALWAYS_USE_WASM`. - Added `host_v1` with a new `peek_next_txs_size` method, that accepts `tx_number_limit` and `size_limit`. - Added new variant of the return type to pass the validation result. It removes block serialization and deserialization and should improve performance. - Added a V1 execution result type that uses `JSONError` instead of postcard serialized error. It adds flexibility of how variants of the error can be managed. More information about it in FuelLabs/fuel-vm#797. The change also moves `TooManyOutputs` error to the top. It shows that `JSONError` works as expected. - Use a WASM generated bytecode for the local testnet since we always want to use the latest version compatible with native execution. ## Checklist - [x] Breaking changes are clearly marked as such in the PR description and changelog - [x] New behavior is reflected in tests ### Before requesting review - [x] I have reviewed the code myself - [x] I have created follow-up issues caused by this PR and linked them here - #2198 - #2200 --------- Co-authored-by: Rafał Chabowski <88321181+rafal-ch@users.noreply.github.com> Co-authored-by: Hannes Karppila <2204863+Dentosal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Because of the way we are doing serialization, we are returning an
ExecutionResultfrom "validate" on the wasm executor. We should be able to handle more cases.See convo:
#1886 (comment)
Include good integ tests to show that this works :)
The text was updated successfully, but these errors were encountered: