Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(CombinedDatabase): handle errors on rolling back auxiliary dbs appropriately #2239

Closed
1 task
rymnc opened this issue Sep 23, 2024 · 0 comments · Fixed by #2272
Closed
1 task

chore(CombinedDatabase): handle errors on rolling back auxiliary dbs appropriately #2239

rymnc opened this issue Sep 23, 2024 · 0 comments · Fixed by #2272
Assignees
@rymnc
Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.

Comments

@rymnc
Copy link
Member

rymnc commented Sep 23, 2024

On b2aa337#diff-c9ec92d6a50c589b6cf389155213049e62dffd865cb2aaf85ebf35a1c74298eaR319-R321

we attempt to sync auxiliary databases with the OnchainDb however, we do not handle errors while doing so.

Definition of Done

  • Rolling back errors are propagated and if on_chain_height / gas_price_height / off_chain_height is unset, swallow the errors
@rymnc rymnc added the tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. label Sep 23, 2024
@rymnc rymnc mentioned this issue Sep 23, 2024
Closed
9 tasks
@rymnc rymnc self-assigned this Oct 1, 2024
@rymnc rymnc mentioned this issue Oct 1, 2024
Merged
9 tasks
@rymnc rymnc linked a pull request Oct 2, 2024 that will close this issue
fix(combined_database): syncing auxiliary databases on startup with custom behaviour #2272
Merged
9 tasks
rymnc added a commit that referenced this issue Oct 3, 2024
@rymnc
fix(combined_database): syncing auxiliary databases on startup with c…
a113238 
…ustom behaviour (#2272)

## Linked Issues/PRs
<!-- List of related issues/PRs -->
Fixes #2239

## Description
<!-- List of detailed changes -->
- Doesn't swallow the error blindly now and errors where necessary, this
should fix the flakiness as well

## Checklist
- [x] Breaking changes are clearly marked as such in the PR description
and changelog
- [x] New behavior is reflected in tests
- [x] [The specification](https://github.com/FuelLabs/fuel-specs/)
matches the implemented behavior (link update PR if changes are needed)

### Before requesting review
- [x] I have reviewed the code myself
- [x] I have created follow-up issues caused by this PR and linked them
here

### After merging, notify other teams

[Add or remove entries as needed]

- [ ] [Rust SDK](https://github.com/FuelLabs/fuels-rs/)
- [ ] [Sway compiler](https://github.com/FuelLabs/sway/)
- [ ] [Platform
documentation](https://github.com/FuelLabs/devrel-requests/issues/new?assignees=&labels=new+request&projects=&template=NEW-REQUEST.yml&title=%5BRequest%5D%3A+)
(for out-of-organization contributors, the person merging the PR will do
this)
- [ ] Someone else?
@netrome netrome closed this as completed Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rymnc rymnc

Labels
tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Milestone
No milestone
2 participants
@netrome @rymnc