-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace usage of surf with lighter-weight http-client #287
Comments
We can't migrate to reqwest since openssl dependencies are being enabled by the graphql client extension framework cynic. Once they release this pr (obmarg/cynic#411), we'll be able to use reqwest without depending on openssl. |
@Voxelot Cynic seems to be taking its sweet time releasing v2. Would it be worth it to fork it and release a forked cynic we can use ourselves? |
Cynic is composed of many libraries, so an alternative is to only use its querygen crate, and wrap it with our own HTTP client. |
Note: http-rs/http-client#98 |
yep! |
surf is bloated with an unmaintained dependency graph containing many security warnings. We should replace it with a lighter-weight solution such as reqwest or hyper.
It should also use rustls or some other non-openssl dependency.
The text was updated successfully, but these errors were encountered: