Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use http-reqwest instead of http-surf #786

Merged
merged 7 commits into from
Nov 25, 2022
Merged

Use http-reqwest instead of http-surf #786

merged 7 commits into from
Nov 25, 2022

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Nov 24, 2022 •
edited
Loading

The bug was reported by the users.

Brandon in slack:

It seems like this is potentially an issue between h1-client (used in surf) and nginx: http-rs/async-h1#108 (comment)

I was able to reproduce the bug the problem is async-h1 used by surf. The usage of reqwest fixes the problem.

Close #596

@xgreenx xgreenx added breaking A breaking api change graphql-api Affects API of the GraphQL labels Nov 24, 2022
@xgreenx xgreenx requested a review from a team November 24, 2022 15:57
@xgreenx xgreenx self-assigned this Nov 24, 2022
bvrooman
bvrooman approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@bvrooman bvrooman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version compatibility tests are nice 👍

ControlCplusControlV
ControlCplusControlV approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@ControlCplusControlV ControlCplusControlV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me, surprised changes were this small

@xgreenx xgreenx merged commit 76ee371 into master Nov 25, 2022
@xgreenx xgreenx deleted the feature/remove-surf branch November 25, 2022 11:32
@xgreenx xgreenx mentioned this pull request Dec 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ControlCplusControlV ControlCplusControlV ControlCplusControlV approved these changes

@bvrooman bvrooman bvrooman approved these changes

Assignees

@xgreenx xgreenx

Labels
breaking A breaking api change graphql-api Affects API of the GraphQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fuel client connection staleness
3 participants
@xgreenx @bvrooman @ControlCplusControlV