Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify chain_id generation and usage across services #824

Closed
xgreenx opened this issue Dec 9, 2022 · 1 comment · Fixed by #827
Closed

Unify chain_id generation and usage across services #824

xgreenx opened this issue Dec 9, 2022 · 1 comment · Fixed by #827
Assignees
@leviathanbeak
Labels
fuel-p2p tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.

Comments

@xgreenx
Copy link
Collaborator

xgreenx commented Dec 9, 2022

#785 (comment)
#785 (comment)

Also, these root functions should exist in the chain-config module so that they can be used without fuel-core. As fuel-p2p is in it's own crate and won't be able to use the genesis module directly.

Means also need to move all stuff regarding the genesis root calculation into fuel-chain-config, because it is where it belongs. Also, Genesis should be a part of the ChainConfig and initial_state field only as metadata without any impact on the root calculation.
@xgreenx xgreenx added tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable. fuel-p2p labels Dec 9, 2022
@xgreenx xgreenx mentioned this issue Dec 9, 2022
Merged
@Voxelot
Copy link
Member

Voxelot commented Dec 9, 2022

initial_state field only as metadata without any impact on the root calculation.

We had a subsequent discussion and decided that the initial state should be included in the global genesis commitment

cc @leviathanbeak

@leviathanbeak leviathanbeak self-assigned this Dec 9, 2022
@leviathanbeak leviathanbeak mentioned this issue Dec 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leviathanbeak leviathanbeak

Labels
fuel-p2p tech-debt The issue is to improve the current code and make it more clear/generic/reusable/pretty/avoidable.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

unify chain id generation and usage FuelLabs/fuel-core
3 participants
@Voxelot @leviathanbeak @xgreenx