unify chain id generation and usage #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…beak/unify_chain_id_generation
xgreenx
reviewed
Dec 10, 2022
xgreenx
reviewed
Dec 10, 2022
* Updated the config to use `Genesis::root` as a checksum * Moved initialization stuff into `fuel-p2p` module. * Make CI happy * Sort imports * Updated the comment for `state`
xgreenx
previously approved these changes
Dec 12, 2022
Dentosal
reviewed
Dec 12, 2022
xgreenx
approved these changes
Dec 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #824
I renamed
Merklizationtrait toGenesisCommitmentand moved it tochain-configmodule.Moved the implementations of the trait to their respective files.
Included few extra fields in
ChainConfighash calculation.Implemented
GenesisCommitmentforGenesiswithinchain-configmodule.Made a wrapper struct Checksum([u8; 32]).