Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pruning of the transaction by TTL #1033

Merged
merged 8 commits into from
Feb 21, 2023
Merged

Pruning of the transaction by TTL #1033

merged 8 commits into from
Feb 21, 2023

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Feb 20, 2023

Added basic pruning of the transaction by the TTL.

It is done periodically for constant period of time. We can do it often(based on the remaining time to the next timeout), but I tried to avoid to often locking.

Voxelot and others added 3 commits February 17, 2023 15:33
…t for now.

Added sorting for transactions by the time submission.
Added pruning of the transactions.
@xgreenx xgreenx marked this pull request as ready for review February 21, 2023 01:02
@xgreenx xgreenx requested a review from a team February 21, 2023 01:07
Replaced `Tai64` with Duration.
Added `tokio::time::instant` into `TxInfo` for more accurate track of the TTL.
Added test to verify that ordering of the transactions.
Voxelot
Voxelot previously approved these changes Feb 21, 2023
Copy link
Member

@Voxelot Voxelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice usage of tokio time to make testing easier!

@xgreenx xgreenx enabled auto-merge (squash) February 21, 2023 22:07
@xgreenx xgreenx merged commit 4100b00 into master Feb 21, 2023
@xgreenx xgreenx deleted the Voxelot/tx-pool-ttl branch February 21, 2023 22:29
xgreenx added a commit that referenced this pull request Feb 21, 2023
## What's Changed
* RESERVED_NODES and BOOTSTRAP_NODES conditional by @rfuelsh in
#1020
* barebones e2e test client by @Voxelot in
#1003
* Graceful Shutdown for all services by @xgreenx in
#1018
* Don't startup p2p or sync services if p2p isn't configured by @Voxelot
in #1021
* update to fuel-vm 0.26.1 by @Voxelot in
#1022
* Remove comment referencing previous defensive programming by
@mitch-fuel in #1024
* Add RUST_LOG option to deployment charts & increase max_transmit_size
by @Voxelot in #1025
* additional integ tests for resources to spend by @Voxelot in
#1026
* Disable pagination args for balances by @Voxelot in
#1027
* Add e2e test to check that Bob can send money back to Alice by
@xgreenx in #1029
* Predicate error handling by @Voxelot in
#1030
* Use composite actions by @tirkesi in
#1032
* Pruning of the transaction by TTL by @xgreenx in
#1033

## New Contributors
* @tirkesi made their first contribution in
#1032

**Full Changelog**:
v0.17.2...v0.17.3
crypto523 pushed a commit to crypto523/fuel-core that referenced this pull request Oct 7, 2024
## What's Changed
* RESERVED_NODES and BOOTSTRAP_NODES conditional by @rfuelsh in
FuelLabs/fuel-core#1020
* barebones e2e test client by @Voxelot in
FuelLabs/fuel-core#1003
* Graceful Shutdown for all services by @xgreenx in
FuelLabs/fuel-core#1018
* Don't startup p2p or sync services if p2p isn't configured by @Voxelot
in FuelLabs/fuel-core#1021
* update to fuel-vm 0.26.1 by @Voxelot in
FuelLabs/fuel-core#1022
* Remove comment referencing previous defensive programming by
@mitch-fuel in FuelLabs/fuel-core#1024
* Add RUST_LOG option to deployment charts & increase max_transmit_size
by @Voxelot in FuelLabs/fuel-core#1025
* additional integ tests for resources to spend by @Voxelot in
FuelLabs/fuel-core#1026
* Disable pagination args for balances by @Voxelot in
FuelLabs/fuel-core#1027
* Add e2e test to check that Bob can send money back to Alice by
@xgreenx in FuelLabs/fuel-core#1029
* Predicate error handling by @Voxelot in
FuelLabs/fuel-core#1030
* Use composite actions by @tirkesi in
FuelLabs/fuel-core#1032
* Pruning of the transaction by TTL by @xgreenx in
FuelLabs/fuel-core#1033

## New Contributors
* @tirkesi made their first contribution in
FuelLabs/fuel-core#1032

**Full Changelog**:
FuelLabs/fuel-core@v0.17.2...v0.17.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants