feat: Use ID types in client api #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
reviewed
May 29, 2023
Voxelot
reviewed
May 29, 2023
xgreenx
reviewed
May 29, 2023
| @@ -750,10 +770,10 @@ impl FuelClient { | |||
| // Retrieve a page of balances by their owner | |||
| pub async fn balances( | |||
| &self, | |||
| owner: &str, | |||
| owner: &Address, | |||
| request: PaginationRequest<String>, | |||
There was a problem hiding this comment.
Hmm, maybe it also would be nice to use a real cursor instead of the String. If that possible, of course
There was a problem hiding this comment.
Yeah, that's worth investigating. I will look into that for this PR.
There was a problem hiding this comment.
As discussed over a call, we can investigate this further at a separate time. I am creating this ticket to capture this tech debt: #1197
xgreenx
reviewed
May 31, 2023
crates/client/src/client.rs
Outdated
| // (Utxos, Messages Nonce) | ||
| excluded_ids: Option<(Vec<&str>, Vec<&str>)>, | ||
| excluded_ids: Option<(Vec<&UtxoId>, Vec<&Nonce>)>, |
There was a problem hiding this comment.
Suggested change
| excluded_ids: Option<(Vec<&UtxoId>, Vec<&Nonce>)>, | |
| excluded_ids: Option<(Vec<UtxoId>, Vec<Nonce>)>, |
xgreenx
approved these changes
May 31, 2023
Merged
xgreenx
added a commit
that referenced
this pull request
Jun 14, 2023
## What's Changed * version compatibility cleanup by @Voxelot in #1171 * Added example with custom query around the `fuel-core-client` by @xgreenx in #1175 * Update to fuel-vm 0.32 (including wideint gas profiling) by @Dentosal in #1173 * feat: Client primitives by @bvrooman in #1144 * Improve executor config by @Voxelot in #1185 * Added `contract_id` to the `ContractConfig` by @xgreenx in #1184 * fix windows file name error by @firedpeanut in #1176 * Make transaction status stream work by @freesig in #1108 * Added `submit_and_await` endpoint to not miss the notifications by @xgreenx in #1192 * feat: Use ID types in client api by @bvrooman in #1191 * Use `fuel-vm 0.33` with predicate estimation by @xgreenx in #1195 * Add transaction lifecycle diagram to the docs by @digorithm in #1201 * sync with peers before producing blocks by @leviathanbeak in #1169 * SMT storage key hashing by @xgreenx in #1207 ## New Contributors * @firedpeanut made their first contribution in #1176 **Full Changelog**: v0.18.1...v0.19.0 --------- Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
crypto523
pushed a commit
to crypto523/fuel-core
that referenced
this pull request
Oct 7, 2024
## What's Changed * version compatibility cleanup by @Voxelot in FuelLabs/fuel-core#1171 * Added example with custom query around the `fuel-core-client` by @xgreenx in FuelLabs/fuel-core#1175 * Update to fuel-vm 0.32 (including wideint gas profiling) by @Dentosal in FuelLabs/fuel-core#1173 * feat: Client primitives by @bvrooman in FuelLabs/fuel-core#1144 * Improve executor config by @Voxelot in FuelLabs/fuel-core#1185 * Added `contract_id` to the `ContractConfig` by @xgreenx in FuelLabs/fuel-core#1184 * fix windows file name error by @firedpeanut in FuelLabs/fuel-core#1176 * Make transaction status stream work by @freesig in FuelLabs/fuel-core#1108 * Added `submit_and_await` endpoint to not miss the notifications by @xgreenx in FuelLabs/fuel-core#1192 * feat: Use ID types in client api by @bvrooman in FuelLabs/fuel-core#1191 * Use `fuel-vm 0.33` with predicate estimation by @xgreenx in FuelLabs/fuel-core#1195 * Add transaction lifecycle diagram to the docs by @digorithm in FuelLabs/fuel-core#1201 * sync with peers before producing blocks by @leviathanbeak in FuelLabs/fuel-core#1169 * SMT storage key hashing by @xgreenx in FuelLabs/fuel-core#1207 ## New Contributors * @firedpeanut made their first contribution in FuelLabs/fuel-core#1176 **Full Changelog**: FuelLabs/fuel-core@v0.18.1...v0.19.0 --------- Co-authored-by: Brandon Kite <brandonkite92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues:
fuel-client-coreinstead of GraphQL types #1121This PR update the
FuelClientAPI to use ID types in place of string serialized IDs. Now, consumers of the API must directly pass a client type when performing a method call. Internally, these ID types are then converted to GraphQL types to be used in the GraphQL API. This API update represents a breaking change.