Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.20.6 with improved and fixed metrics #1406

Merged
merged 5 commits into from
Oct 6, 2023

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Oct 6, 2023

Release includes #1405 and #1355

xgreenx and others added 4 commits October 6, 2023 11:31
closes: #1163

Adds the following metrics to prometheus:

- `importer_tx_count`
- `importer_block_height`
- `importer_latest_block_commit_timestamp_s`
- `importer_execute_and_commit_duration_s`

Additional related changes:
- New field in the metadata table to keep track of the total number of
transactions so that the metric is accurate across restarts
- Removed the compiler feature flag for "metrics" since it was sneaked
into all builds anyways with the addition of futures tracking.

This allows us to _finally_ start measuring the following:
- Transactions per second
- Delays in synchronization (ie. comparing the block heights between
nodes, and comparing the committed timestamps)
- Various measures of time related to block importing/execution on
synchronizing nodes (i.e. validation mode) such as avg, max, min etc

---------

Co-authored-by: Brandon Vrooman <brandon.vrooman@gmail.com>

(cherry picked from commit ca241e2)
@xgreenx xgreenx requested review from Voxelot and a team October 6, 2023 10:00
@xgreenx xgreenx self-assigned this Oct 6, 2023
@Dentosal
Copy link
Member

Dentosal commented Oct 6, 2023

cargo-audit is failing, likely because of https://github.com/FuelLabs/fuel-core/security/dependabot/37

Copy link
Member

@Dentosal Dentosal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I bumped CI Rust version as well, seems like many updates are due to 1.72.0 clippy.

@xgreenx xgreenx merged commit 93205c9 into release/0.20.6 Oct 6, 2023
20 of 21 checks passed
@xgreenx xgreenx deleted the hotfix/metrics branch October 6, 2023 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants