Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack Notifications for Worfklow Job Failures #156

Merged
merged 10 commits into from
Feb 10, 2022
Merged

Conversation

rfuelsh
Copy link
Member

@rfuelsh rfuelsh commented Feb 3, 2022

For all jobs in the ci.yml, slack notifications will be sent if the job fails at any point.

For the build job, a slack alert will only be sent if the branch is master upon which the workflow is running.

This was tested and the results are in #notify-build of our slack.

@rfuelsh rfuelsh linked an issue Feb 3, 2022 that may be closed by this pull request
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@rfuelsh rfuelsh requested a review from adlerjohn February 3, 2022 20:11
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay to me I guess, but will defer to @Voxelot

Copy link
Member

@Voxelot Voxelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, although I think we should really try to use action templates before copying these around to all the other repos. That way we have one place to control all the notifications.

@rfuelsh rfuelsh merged commit a3b7c5b into master Feb 10, 2022
@rfuelsh rfuelsh deleted the roy/notify-ci-failures branch February 10, 2022 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Notify Master and Release CI Failures
3 participants