-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Slack Notifications for Worfklow Job Failures #156
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks okay to me I guess, but will defer to @Voxelot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, although I think we should really try to use action templates before copying these around to all the other repos. That way we have one place to control all the notifications.
For all jobs in the ci.yml, slack notifications will be sent if the job fails at any point.
For the build job, a slack alert will only be sent if the branch is master upon which the workflow is running.
This was tested and the results are in #notify-build of our slack.