Receipt saving bug #177
Merged
Receipt saving bug #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iqdecay
previously approved these changes
Feb 17, 2022
iqdecay
dismissed
their stale review
The code does not seem to compile actually
|
Fixed the block typo, and testing it locally is a success! thanks a lot |
digorithm
approved these changes
Feb 17, 2022
|
ah thanks for the fix - I was just waking up |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a bug where receipts aren't saved if the transaction panics. They were being saved to the wrong database transaction which gets dropped if the tx panics, and should only be used for state changes from the script execution.