Fix RocksDb issue, ensure rocksdb runs in CI #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adlerjohn
reviewed
Mar 5, 2022
adlerjohn
reviewed
Mar 5, 2022
AlicanC
approved these changes
Mar 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After adding a new column to the database, I forgot to increment the column number constant which was causing errors at runtime.
To avoid this from happening again, I made it so that the tests run twice, once with default features enabled (rocksdb) and again with default features disabled (in-memory).
However, due to the way our integ tests in fuel-gql-client were setup, it was causing a bug in the v2 feature resolver when attempting to use
cargo test --no-default-features. Specifically, it seemed like the feature resolver was unifying dev-deps in the fuel-gql-client with the fuel-core crate in the workspace, causing fuel-core to always be compiled with default features enabled when using--no-default-featuresat the workspace level. In order to fix this and make it possible to run tests without default features enabled on fuel-core, I had to move all the integ tests into their own crate (with normal deps only). This is better in the long run and is more similar to how projects like diesel-rs are structured.