Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore the message receipt if transaction is reverted #2045

Merged
merged 5 commits into from
Jul 27, 2024

Conversation

xgreenx
Copy link
Collaborator

@xgreenx xgreenx commented Jul 23, 2024

Include withdrawal message only if transaction is executed successfully, otherwise it is possible to use same assets to create many withdrawals with failed transactions.

The network is patched already with a private fix.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests

Before requesting review

  • I have reviewed the code myself

@xgreenx xgreenx requested a review from a team July 23, 2024 23:19
@xgreenx xgreenx self-assigned this Jul 23, 2024
crates/fuel-core/src/executor.rs Outdated Show resolved Hide resolved
crates/fuel-core/src/executor.rs Show resolved Hide resolved
@Dentosal Dentosal requested a review from MitchTurner July 26, 2024 11:45
@Dentosal Dentosal merged commit 1cfbb05 into master Jul 27, 2024
34 checks passed
@Dentosal Dentosal deleted the bugfix/ingore-message-receipt-if-reverted branch July 27, 2024 11:57
@MitchTurner MitchTurner mentioned this pull request Aug 2, 2024
MitchTurner added a commit that referenced this pull request Aug 6, 2024
## What's Changed
* L2 Block Source & Metadata Storage implementations by @MitchTurner in
#1983
* Weekly `cargo update` by @github-actions in
#2029
* Add V0 algorithm to actual services by @MitchTurner in
#2025
* Weekly `cargo update` by @github-actions in
#2039
* Add syncronization for Gas Price Database and On Chain Database on
startup by @MitchTurner in
#2041
* Ignore the message receipt if transaction is reverted by @xgreenx in
#2045
* feat: add chain config to Docker images by @mchristopher in
#2052
* Blob tx support and fuel-vm 0.56.0 by @Dentosal in
#1988
* Disable SMT for `ContractsAssets` and `ContractsState` by @xgreenx in
#2048

## New Contributors
* @mchristopher made their first contribution in
#2052

**Full Changelog**:
v0.31.0...v0.32.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants