Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: publish to public ECR repo #2066

Merged
merged 9 commits into from
Aug 15, 2024
Merged

feat: publish to public ECR repo #2066

merged 9 commits into from
Aug 15, 2024

Conversation

mchristopher
Copy link
Member

Publishing Docker image builds to ECR so that production instances do not need to rely on GitHub infrastructure during runtime.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

@mchristopher mchristopher added the no changelog Skip the CI check of the changelog modification label Aug 8, 2024
@mchristopher mchristopher marked this pull request as ready for review August 9, 2024 01:44
@mchristopher mchristopher requested review from Voxelot and xgreenx August 9, 2024 01:44
@mchristopher mchristopher enabled auto-merge (squash) August 9, 2024 18:12
@mchristopher mchristopher merged commit be0b630 into master Aug 15, 2024
28 checks passed
@mchristopher mchristopher deleted the publish-to-ecr branch August 15, 2024 16:25
@xgreenx xgreenx mentioned this pull request Aug 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voxelot Voxelot Voxelot approved these changes

@xgreenx xgreenx Awaiting requested review from xgreenx xgreenx is a code owner

Assignees
No one assigned
Labels
no changelog Skip the CI check of the changelog modification
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mchristopher @Voxelot @Dentosal