Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change relayer URI address to be vector and use quorum provider #2122

Merged
merged 13 commits into from
Aug 27, 2024
Merged

Change relayer URI address to be vector and use quorum provider #2122

merged 13 commits into from
Aug 27, 2024

Conversation

AurelienFT
Copy link
Contributor

@AurelienFT AurelienFT commented Aug 21, 2024 •
edited by xgreenx
Loading

Linked Issues/PRs

Closes #2118

Description

This PR include the change to allow multiple RPC directly in our relayer code. It allows relayer users to pass multiple RPC addresses in CLI and the response to a RPC call will be accepted only if it's the same given by 50% or more of the RPC provider.

It shouldn't be a breaking change as the current format of the --relayer argument will still be valid and will result in a simple RPC call.

Checklist

  • Breaking changes are clearly marked as such in the PR description and changelog
  • New behavior is reflected in tests
  • The specification matches the implemented behavior (link update PR if changes are needed)

Before requesting review

  • I have reviewed the code myself
  • I have created follow-up issues caused by this PR and linked them here

After merging, notify other teams

@AurelienFT AurelienFT marked this pull request as ready for review August 21, 2024 21:41
@AurelienFT AurelienFT changed the title Change relayer uri address to be vector and use quorum addresses Change relayer URI address to be vector and use quorum provider Aug 21, 2024
@AurelienFT AurelienFT requested a review from a team August 21, 2024 21:43
@AurelienFT AurelienFT mentioned this pull request Aug 21, 2024
Closed
@rymnc
Copy link
Member

rymnc commented Aug 22, 2024

what is the behaviour of the quorum provider when a majority of the provided RPC are down? does it return an error, or just the minority response?

xgreenx
xgreenx reviewed Aug 22, 2024
View reviewed changes
crates/services/relayer/src/config.rs Show resolved Hide resolved
tests/tests/relayer.rs Outdated Show resolved Hide resolved
MitchTurner
MitchTurner reviewed Aug 22, 2024
View reviewed changes
tests/tests/relayer.rs Outdated Show resolved Hide resolved
tests/tests/relayer.rs Outdated Show resolved Hide resolved
tests/tests/relayer.rs Outdated Show resolved Hide resolved
netrome
netrome reviewed Aug 22, 2024
View reviewed changes
tests/tests/relayer.rs Outdated Show resolved Hide resolved
@AurelienFT
Copy link
Contributor Author

what is the behaviour of the quorum provider when a majority of the provided RPC are down? does it return an error, or just the minority response?

It returns an error NoQuorumReached with the values and the errors gathered. I will try to change the tests to highlight more this behavior

xgreenx
xgreenx previously approved these changes Aug 26, 2024
View reviewed changes
@xgreenx xgreenx enabled auto-merge (squash) August 26, 2024 17:44
xgreenx
xgreenx reviewed Aug 26, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
xgreenx
xgreenx previously approved these changes Aug 26, 2024
View reviewed changes
@AurelienFT AurelienFT requested a review from xgreenx August 27, 2024 07:14
netrome
netrome previously approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@netrome netrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit, otherwise LGTM.

crates/services/relayer/src/service/test.rs Outdated Show resolved Hide resolved
@AurelienFT @netrome
Update crates/services/relayer/src/service/test.rs
62730f2 
Co-authored-by: Mårten Blankfors <nilssonmartenx@gmail.com>
xgreenx
xgreenx previously approved these changes Aug 27, 2024
View reviewed changes
@AurelienFT AurelienFT requested review from netrome and xgreenx August 27, 2024 08:08
@xgreenx xgreenx merged commit 198c158 into master Aug 27, 2024
30 checks passed
@xgreenx xgreenx deleted the use_multiple_provider_rpc_eth branch August 27, 2024 08:34
@xgreenx xgreenx mentioned this pull request Aug 28, 2024
Merged
xgreenx added a commit that referenced this pull request Aug 28, 2024
@xgreenx
Release v0.35.0 (#2136)
9f96573 
## Version v0.35.0

### Added
- [2122](#2122): Changed the
relayer URI address to be a vector and use a quorum provider. The
`relayer` argument now supports multiple URLs to fetch information from
different sources.
- [2119](#2119): GraphQL query
fields for retrieving information about upgrades.

### Changed
- [2113](#2113): Modify the
way the gas price service and shared algo is initialized to have some
default value based on best guess instead of `None`, and initialize
service before graphql.
- [2112](#2112): Alter the way
the sealed blocks are fetched with a given height.
- [2120](#2120): Added
`submitAndAwaitStatus` subscription endpoint which returns the
`SubmittedStatus` after the transaction is submitted as well as the
`TransactionStatus` subscription.
- [2115](#2115): Add test for
`SignMode` `is_available` method.
- [2124](#2124): Generalize
the way p2p req/res protocol handles requests.

#### Breaking

- [2040](#2040): Added full
`no_std` support state transition related crates. The crates now require
the "alloc" feature to be enabled. Following crates are affected:
  - `fuel-core-types`
  - `fuel-core-storage`
  - `fuel-core-executor`
- [2116](#2116): Replace
`H160` in config and cli options of relayer by `Bytes20` of `fuel-types`

### Fixed
- [2134](#2134): Perform
RecoveryID normalization for AWS KMS -generated signatures.

## What's Changed
* Change TODO clippy to wait for false positive correction by
@AurelienFT in #2110
* Remove option on shared algo, give default algo, reorder service
startup by @MitchTurner in
#2113
* chore(sealed_blocks): optimize fetching of sealed block header at a
given height by @rymnc in
#2112
* chore(p2p_service): remove unnecessary cast to usize by @rymnc in
#2123
* Added a benchmark for the predicate with ed19 verification by @xgreenx
in #2127
* Add test SignMode is_available by @AurelienFT in
#2115
* feat: Add graphql query fields for retreiving information about
upgrades by @netrome in #2119
* Small code optimizations by @MoneyBund in
#2035
* Change relayer URI address to be vector and use quorum provider by
@AurelienFT in #2122
* chore(p2p_service): clean up processing of p2p req/res protocol by
@rymnc in #2124
* feat: add `submitAndAwaitStatus` subscription endpoint by @maschad in
#2120
* Replace H160 in config and cli options of relayer by Bytes20 by
@AurelienFT in #2116
* Secp256k1 RecoveryID correction for KMS-genrated signatures by
@Dentosal in #2134
* Added `no_std` support state transition related crates by @xgreenx in
#2040

## New Contributors
* @MoneyBund made their first contribution in
#2035
* @maschad made their first contribution in
#2120

**Full Changelog**:
v0.34.0...v0.35.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Voxelot Voxelot Voxelot left review comments

@netrome netrome netrome approved these changes

@xgreenx xgreenx xgreenx approved these changes

@MitchTurner MitchTurner Awaiting requested review from MitchTurner MitchTurner is a code owner

Assignees

@AurelienFT AurelienFT

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fetch L1 data from different RPC providers
6 participants
@AurelienFT @rymnc @Voxelot @MitchTurner @xgreenx @netrome