Add initialization for the genesis base asset contract #2304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Voxelot
approved these changes
Oct 6, 2024
xgreenx
deleted the
hotfix/initialize-state-of-the-genesis-base-contract
branch
rymnc
reviewed
Oct 6, 2024
| let key = ContractsStateKey::new(contract_id, &storage_key); | ||
| let contains = storage | ||
| .storage_as_mut::<ContractsState>() | ||
| .contains_key(&key)?; |
There was a problem hiding this comment.
qq: what was the previous value stored in the keys defined by STATE? does zeroing them out fix it?
Comment on lines
+127
to
+130
| let entries = view | ||
| .iter_all::<ContractsState>(None) | ||
| .map(|r| r.unwrap()) | ||
| .collect::<Vec<_>>(); |
There was a problem hiding this comment.
iter_all_keys perhaps? but then again, we don't test the values and this length would be the same before and after running maybe_fix_contract right?
Merged
xgreenx
added a commit
that referenced
this pull request
Oct 7, 2024
## Version v0.37.1 ### Fixed - [2304](#2304): Add initialization for the genesis base asset contract. ## What's Changed * Add initialization for the genesis base asset contract by @xgreenx in #2304 **Full Changelog**: v0.37.0...v0.37.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This match initializes storage slots for the genesis base asset contract(because we forgot to add it).
In the next release we will remove it form our codebase=)
Side change:
ChangesIteratorto thefuel-core-storagecrate to allow usage in the tests.Checklist
Before requesting review