Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuel-gql-client support for "https://" #266

Merged
merged 2 commits into from
Apr 15, 2022
Merged

fuel-gql-client support for "https://" #266

merged 2 commits into from
Apr 15, 2022

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Apr 15, 2022

Fuel gql client accepted a string for instantiation but always parsed it as a socket addr so that it could be formatted in a way that is guaranteed to be the correct route for the fuel node. The problem with this approach is that it always assumes the client URL will be on http. This change allows the string to be directly passed in and parsed as the URL of the fuel-core graphql endpoint, allowing users to set https in the prefix if needed.

@Voxelot Voxelot requested review from adlerjohn and vlopes11 April 15, 2022 05:48
@Voxelot Voxelot self-assigned this Apr 15, 2022
@Voxelot Voxelot requested a review from digorithm April 15, 2022 05:49
@Voxelot
Copy link
Member Author

Voxelot commented Apr 15, 2022

We will need this for rust sdk users hitting hosted environments behind SSL certs @digorithm

Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@Voxelot Voxelot merged commit c1f9290 into master Apr 15, 2022
@Voxelot Voxelot deleted the client-ssl branch April 15, 2022 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants