Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pin async-graphql 2.9 again #289

Merged
merged 3 commits into from
Apr 27, 2022
Merged

Pin async-graphql 2.9 again #289

merged 3 commits into from
Apr 27, 2022

Conversation

Voxelot
Copy link
Member

@Voxelot Voxelot commented Apr 27, 2022

don't use newer version of async-graphql until newer release is fixed

@Voxelot Voxelot requested review from rakita and adlerjohn April 27, 2022 20:41
@Voxelot Voxelot self-assigned this Apr 27, 2022
adlerjohn
adlerjohn reviewed Apr 27, 2022
View reviewed changes
Copy link
Contributor

@adlerjohn adlerjohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a comment on why this is pinned, otherwise it looks like an error since we haven't been the most diligent with dep versions.

@Voxelot Voxelot merged commit 0e78e21 into master Apr 27, 2022
@Voxelot Voxelot deleted the pin-async-gql-again branch April 27, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adlerjohn adlerjohn adlerjohn approved these changes

@rakita rakita Awaiting requested review from rakita

Assignees

@Voxelot Voxelot

Labels
None yet
Projects
Fuel Network
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Voxelot @adlerjohn