Wrap txpool sender #438
Wrap txpool sender #438
Conversation
rakita
requested review from
ControlCplusControlV,
leviathanbeak,
vlopes11 and
Voxelot
| @@ -26,6 +27,65 @@ pub trait TxPoolDb: | |||
| } | |||
| } | |||
|
|
|||
| #[derive(Clone, Deref, DerefMut)] | |||
| pub struct Sender(mpsc::Sender<TxPoolMpsc>); | |||
There was a problem hiding this comment.
[nit] I think we could increase the simplicity even further by making this abstraction avoid channel terminology as much as possible. Focusing on emphasizing the capabilities and intention of this facade, vs the mechanics of how it interacts with other components at a lower level.
| pub struct Sender(mpsc::Sender<TxPoolMpsc>); | |
| pub struct TxPoolClient(mpsc::Sender<TxPoolMpsc>); |
There was a problem hiding this comment.
I like this naming, will make the change.
There was a problem hiding this comment.
Why is moving away from channel terminology a good thing when this is just a wrapper and channels are async primitives? As with Client, we are adding new abstraction naming when in essence it is mpsc::Sender inside.
I made the change here, but while coding the naming felt weird. 288ccef
|
thanks for cleaning up the |
Wrap txpool mpsc::Sender around Sender structure that gives us better ergonomic in calling functionalities from txpool,
related to: #429