implement DummyDB functionality for tests #441
Conversation
thdaraujo
changed the title
thdaraujo
changed the title
thdaraujo
force-pushed
the
ta/implement-dummydb
branch
from
1056df5 to
0194465
Compare
| @@ -166,7 +166,7 @@ pub mod helpers { | |||
| /// Dummy coins | |||
| pub coins: HashMap<UtxoId, Coin>, | |||
| /// Dummy contracts | |||
| pub contract: HashSet<ContractId>, | |||
| pub contract: HashMap<ContractId, Contract>, | |||
There was a problem hiding this comment.
I'm assuming here that this should be a Map and not a Set.
thdaraujo
force-pushed
the
ta/implement-dummydb
branch
from
a018cfe to
bf605ce
Compare
thdaraujo
force-pushed
the
ta/implement-dummydb
branch
from
bf605ce to
4554652
Compare
thdaraujo
changed the title
|
Do you have any tests for this? Or how have you been testing your changes? |
Yep! I do have some tests, but they look a bit repetitive. I was trying to make them more generic, but probably the only way is by using macros. I'll commit my tests for transactions to show you what I mean @ControlCplusControlV |
| unreachable!() | ||
| let arc = Arc::new(value.clone()); | ||
|
|
||
| if let Some(previous_tx) = self.data.lock().tx.insert(*key, arc) { |
There was a problem hiding this comment.
FYI: this method will return the old value (the replaced value) that was overwritten. That was my understanding after reading this:
https://github.com/FuelLabs/fuel-storage/blob/62f163dc21c712e2fa8dd9a6a76cf94f82ffc0d0/src/lib.rs#L27
fuel-core-interfaces/src/db.rs
Outdated
| let key = value.id(); | ||
|
|
||
| //before insert | ||
| assert!(!db.contains_key(&key)?); |
There was a problem hiding this comment.
I would like to reuse all the tests below and only change the db, value and key for the specific implementation. That way, I could remove some duplication.
But not entirely sure how to do it without macros or leveraging generics. Maybe you have a better suggestion.
There was a problem hiding this comment.
I'd recommend looking into rstest as we already use it in other areas. The db could be instantiated via fixture.
There was a problem hiding this comment.
Thanks for the info!
I added more test cases and removed most of the duplication, and also found a way to to instantiate the db without needing fixtures after all.
[fixes #431]
Implements DummyDB functionality to be used on other tests.