TxPool ServiceBuilder and Context #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakita
force-pushed
the
rakita/txpool_builder
branch
from
1239580 to
bc777d5
Compare
rakita
force-pushed
the
rakita/txpool_builder
branch
from
1f4461b to
ac2a7f6
Compare
Voxelot
reviewed
Jul 8, 2022
| broadcast: broadcast::Sender<TxStatusBroadcast>, | ||
| txs: Vec<ArcTx>, | ||
| ) -> Vec<anyhow::Result<Vec<ArcTx>>> { | ||
| // Check if that data is okay (witness match input/output, and if recovered signatures ara valid). |
There was a problem hiding this comment.
The new CheckedTranasction type will make this easier once Victor has finished implementing in fuel-vm.
There was a problem hiding this comment.
Yeah, it makes a lot of sense to have it.
Voxelot
reviewed
Jul 8, 2022
Voxelot
previously approved these changes
Jul 8, 2022
Voxelot
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
Interfaceand move its functionality toTxPoolstruct.introduce
ServiceBuilderandContext