Controlc/block api #461
Merged
Controlc/block api #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should have a config option for the node to disable this behavior in production. Otherwise strange things could happen. |
Oh true, wasn't sure how exactly best to do this. Should this endpoint be specifically addressed (ie config option like |
Co-authored-by: Elvis <elvisdedic@outlook.com>
|
@Voxelot I've updated this to require a config option to enabled (which is disabled by default) for this endpoint to work, and added a negative test to ensure it's off by default |
iqdecay
suggested changes
Jul 6, 2022
Voxelot
reviewed
Jul 6, 2022
Voxelot
reviewed
Jul 6, 2022
iqdecay
previously requested changes
Jul 7, 2022
Voxelot
approved these changes
Jul 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a simple
advance_blockendpoint, which takes in an option of the amount to advance forward the block-height by (defaulting to 1 if nothing is supplied). I then inserts n emptyFuelBlocks, and returns the new block-height. I was hoping to confirm this was inline with what you were looking for @vnepveu ?Closes #455